c-mode: respect user-defined tab width for indentation #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please include an example, preferably in the commit message, of how to replicate the problem your patch fixes? It may be evident to you, but for a reviewer it's very difficult to guess what it is you've seen. |
Example: 1. set a custom tab width via `set-tab-width` (e.g., 4). 2. open c-mode, type of block of C code, and indent. Expected behavior: One tab character per indentation level (or spaces if no-tab-mode enabled). Actual behavior: Multiple tabs/spaces inserted to reach an indentation of 8 columns. This patch updates `getindent` to respect the user-defined tab width (`curbp->b_tabw`) when calculating indentation levels, instead of always assuming 8 columns. Previously, when the user set `set-tab-width` to 4, `c-mode` would request 8 columns of indentation, resulting in two tab characters being inserted instead of one. This caused incorrect indentation for KNF-compliant code.
dhennigar
force-pushed
the
cmode-tab-handling
branch
from
3709546 to
5358aeb
Compare
|
I've updated the commit message with an example of how to replicate the issue. Let me know if you need further details! |
|
Thanks, replicated, good fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c-mode: Respect user-define tab width for indentation
This patch updates
getindentto use the current buffer’s tab width(
curbp->b_tabw) when calculating indentation levels, instead ofalways assuming 8 columns.
It ensures that c-mode behaves correctly with user-configurable tab
widths set via
set-tab-width, while keeping the default behaviorKNF-compliant.